From f9852751dac77b1458cfa5a1d5a058628ea8d25e Mon Sep 17 00:00:00 2001 From: kutesir Date: Thu, 9 Jul 2026 22:40:54 +0300 Subject: [PATCH] workout: revert Finish-at-100% confirmation, keep dots-always-visible fix (KC-63 follow-up) Confirming every Finish tap was unwanted friction once all sets are already checked. Restored the one-tap Finish at 100% (partial completion still confirms via "Finish Anyway"); the always-visible progress dots from the first part of KC-63 are unchanged. Co-Authored-By: Claude Opus 4.8 --- KisaniCal/ISSUES.md | 8 ++++++++ KisaniCal/Views/WorkoutView.swift | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/KisaniCal/ISSUES.md b/KisaniCal/ISSUES.md index 32f4951..395e4fc 100644 --- a/KisaniCal/ISSUES.md +++ b/KisaniCal/ISSUES.md @@ -2221,3 +2221,11 @@ Files: `KisaniCal/Views/WorkoutView.swift`. ### Note Not build-verified (no iOS runtime here). Self-reviewed: balanced braces/ parens confirmed for the file. + +### Follow-up — Finish-at-100% confirmation reverted +User pushed back on the "confirm every Finish tap" part: at 100% sets, +tapping "Finish Workout" going through a confirmation dialog was +unwanted friction, not a fix — restored the KC-52 behavior where Finish +skips the dialog only when `done == total` (nothing to override at that +point). Partial-completion "Finish Anyway" still confirms. The +always-visible progress dots from this issue's first change are untouched. diff --git a/KisaniCal/Views/WorkoutView.swift b/KisaniCal/Views/WorkoutView.swift index d7cd761..ce2d300 100644 --- a/KisaniCal/Views/WorkoutView.swift +++ b/KisaniCal/Views/WorkoutView.swift @@ -740,7 +740,7 @@ struct DotProgressCard: View { private var actionRow: some View { VStack(spacing: 8) { Button { - pendingAction = .finish + if done == total && total > 0 { onFinish() } else { pendingAction = .finish } } label: { Label(done == total && total > 0 ? "Finish Workout" : "Finish Anyway", systemImage: "checkmark.circle.fill")