kutesir/KisaniCal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

habits: clarify the custom coffee reminder row (KC-58)

Browse Source 
The custom-slot row just said 'Coffee' -- identical-looking to the card's own
'Coffee reminders' title, with no affordance signaling it's an editable,
user-nameable 5th slot (distinct from the 4 fixed Morning/Midday/Afternoon/
Evening ones).

Added a small pencil + 'YOUR OWN REMINDER' label above the field; changed the
default from pre-filled 'Coffee' to empty so the placeholder ('Name it, e.g.
"Second coffee"') actually does its job. NotificationManager falls back to
'Coffee' for the notification text only if the user never typed a name.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
kutesir
2026-07-09 02:39:35 +03:00
committed by kutesir
parent a6e21e3b52
commit ec58032246
3 changed files with 49 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
KisaniCal/ISSUES.md
View File

@@ -1965,3 +1965,25 @@ how every other color in the app is centralized, and is accessible from any
file.
Files: `DesignTokens.swift`, `SettingsView.swift`, `OnboardingView.swift`.
---
## KC-58 — Custom coffee reminder row was unlabeled/confusing
**Status:** Implemented (not build-verified)
**Reported by:** User (screenshot: last row in "Coffee reminders" just said
"Coffee" — indistinguishable from the card's own title, no hint it's an
editable custom slot)
### Fix
- The custom-reminder row now has a small "✎ YOUR OWN REMINDER" label above
it, so it reads as a distinct, nameable 5th slot rather than a redundant
duplicate of the "Coffee reminders" card title.
- Default label changed from the confusing pre-filled "Coffee" to empty, so
the field's placeholder ("Name it, e.g. \"Second coffee\"") actually guides
the user instead of looking like a static, already-filled-in option.
- `NotificationManager` falls back to "Coffee" for the notification title only
if the user never actually typed a name (empty string), so an un-customized
custom reminder still reads sensibly if enabled.
Files: `SettingsView.swift`, `NotificationManager.swift`.

5
KisaniCal/Managers/NotificationManager.swift
View File

@@ -265,7 +265,10 @@ final class NotificationManager: NSObject, ObservableObject, @unchecked Sendable
habitType: "coffee"
)
}
let customLabel = ud.string(forKey: "coffeeCustomLabel") ?? "Coffee"
// Empty until the user names it (the field's placeholder guides that) —
// fall back to a sensible default rather than an empty notification title.
let rawCustomLabel = ud.string(forKey: "coffeeCustomLabel") ?? ""
let customLabel = rawCustomLabel.isEmpty ? "Coffee" : rawCustomLabel
addDaily(
id: "\(Self.habitPrefix).coffee.custom",
enabled: coffeeOn && (ud.object(forKey: "coffeeCustomEnabled") as? Bool ?? false),

11
KisaniCal/Views/SettingsView.swift
View File

@@ -916,7 +916,7 @@ private struct HabitRemindersSheet: View {
@AppStorage("coffeeReminderEnabled", store: UserDefaults.kisani) private var coffeeReminderEnabled = false
@AppStorage("coffeeCustomEnabled", store: UserDefaults.kisani) private var coffeeCustomEnabled = false
@AppStorage("coffeeCustomLabel", store: UserDefaults.kisani) private var coffeeCustomLabel = "Coffee"
@AppStorage("coffeeCustomLabel", store: UserDefaults.kisani) private var coffeeCustomLabel = ""
@AppStorage("coffeeCustomHour", store: UserDefaults.kisani) private var coffeeCustomHour = 16
@AppStorage("coffeeCustomMinute", store: UserDefaults.kisani) private var coffeeCustomMinute = 30
@@ -1020,8 +1020,14 @@ private struct HabitRemindersSheet: View {
defaultMinute: 0, defaultEnabled: slot == "Morning")
}
Divider().background(AppColors.border(cs)).padding(.leading, 14)
VStack(alignment: .leading, spacing: 5) {
HStack(spacing: 4) {
Image(systemName: "pencil").font(.system(size: 9))
Text("YOUR OWN REMINDER").font(AppFonts.mono(8, weight: .bold))
}
.foregroundColor(AppColors.text3(cs))
HStack(spacing: 11) {
TextField("Custom label", text: $coffeeCustomLabel)
TextField("Name it, e.g. \"Second coffee\"", text: $coffeeCustomLabel)
.font(AppFonts.sans(12.5)).foregroundColor(AppColors.text(cs))
Spacer()
if coffeeCustomEnabled {
@@ -1037,6 +1043,7 @@ private struct HabitRemindersSheet: View {
}
Toggle("", isOn: $coffeeCustomEnabled).labelsHidden().tint(AppColors.accent).scaleEffect(0.85)
}
}
.padding(.horizontal, 14).padding(.vertical, 9)
}
}