workout: revert Finish-at-100% confirmation, keep dots-always-visible fix (KC-63 follow-up)
Some checks failed
CI / build-and-test (push) Has been cancelled
Some checks failed
CI / build-and-test (push) Has been cancelled
Confirming every Finish tap was unwanted friction once all sets are already checked. Restored the one-tap Finish at 100% (partial completion still confirms via "Finish Anyway"); the always-visible progress dots from the first part of KC-63 are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -2221,3 +2221,11 @@ Files: `KisaniCal/Views/WorkoutView.swift`.
|
|||||||
### Note
|
### Note
|
||||||
Not build-verified (no iOS runtime here). Self-reviewed: balanced braces/
|
Not build-verified (no iOS runtime here). Self-reviewed: balanced braces/
|
||||||
parens confirmed for the file.
|
parens confirmed for the file.
|
||||||
|
|
||||||
|
### Follow-up — Finish-at-100% confirmation reverted
|
||||||
|
User pushed back on the "confirm every Finish tap" part: at 100% sets,
|
||||||
|
tapping "Finish Workout" going through a confirmation dialog was
|
||||||
|
unwanted friction, not a fix — restored the KC-52 behavior where Finish
|
||||||
|
skips the dialog only when `done == total` (nothing to override at that
|
||||||
|
point). Partial-completion "Finish Anyway" still confirms. The
|
||||||
|
always-visible progress dots from this issue's first change are untouched.
|
||||||
|
|||||||
@@ -740,7 +740,7 @@ struct DotProgressCard: View {
|
|||||||
private var actionRow: some View {
|
private var actionRow: some View {
|
||||||
VStack(spacing: 8) {
|
VStack(spacing: 8) {
|
||||||
Button {
|
Button {
|
||||||
pendingAction = .finish
|
if done == total && total > 0 { onFinish() } else { pendingAction = .finish }
|
||||||
} label: {
|
} label: {
|
||||||
Label(done == total && total > 0 ? "Finish Workout" : "Finish Anyway",
|
Label(done == total && total > 0 ? "Finish Workout" : "Finish Anyway",
|
||||||
systemImage: "checkmark.circle.fill")
|
systemImage: "checkmark.circle.fill")
|
||||||
|
|||||||
Reference in New Issue
Block a user