workout: revert Finish-at-100% confirmation, keep dots-always-visible fix (KC-63 follow-up)
Some checks failed
CI / build-and-test (push) Has been cancelled

Confirming every Finish tap was unwanted friction once all sets are
already checked. Restored the one-tap Finish at 100% (partial
completion still confirms via "Finish Anyway"); the always-visible
progress dots from the first part of KC-63 are unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
kutesir
2026-07-09 22:40:54 +03:00
parent 9e06b56a43
commit f9852751da
2 changed files with 9 additions and 1 deletions

View File

@@ -2221,3 +2221,11 @@ Files: `KisaniCal/Views/WorkoutView.swift`.
### Note
Not build-verified (no iOS runtime here). Self-reviewed: balanced braces/
parens confirmed for the file.
### Follow-up — Finish-at-100% confirmation reverted
User pushed back on the "confirm every Finish tap" part: at 100% sets,
tapping "Finish Workout" going through a confirmation dialog was
unwanted friction, not a fix — restored the KC-52 behavior where Finish
skips the dialog only when `done == total` (nothing to override at that
point). Partial-completion "Finish Anyway" still confirms. The
always-visible progress dots from this issue's first change are untouched.

View File

@@ -740,7 +740,7 @@ struct DotProgressCard: View {
private var actionRow: some View {
VStack(spacing: 8) {
Button {
pendingAction = .finish
if done == total && total > 0 { onFinish() } else { pendingAction = .finish }
} label: {
Label(done == total && total > 0 ? "Finish Workout" : "Finish Anyway",
systemImage: "checkmark.circle.fill")